← Back to team overview

openjdk team mailing list archive

[Bug 255149]

 

details: http://icedtea.classpath.org//people/andrew/icedtea8?cmd=changeset;node=8dc6e1ff8ccf
author: Andrew John Hughes <ahughes@xxxxxxxxxx>
date: Thu May 20 14:37:32 2010 +0100

        Fix a number of issues and enable the Rhino rewriter in the
build.

        2010-02-17 Andrew John Hughes  <ahughes@xxxxxxxxxx>

		PR icedtea/179
		* ChangeLog: Remove rogue whitespace highlighted
		by emacs.
		* Makefile.am:
		(REWRITER_SRCS): Sources for class file rewriter.
		Only set RHINO_JAR when WITH_RHINO is set.  Point
		to rewritten JAR file in build directory.  Add
		rewriter and license to EXTRA_DIST.  Make icedtea,
		icedtea-debug and icedtea-boot depend on rewrite-rhino.stamp.
		(stamps/rewriter.stamp): Build the class file rewriter.
		(stamps/rewrite-rhino.stamp): Rewrite the system Rhino JAR
		file to use the sun.org.mozilla namespace to avoid conflicts.
		(rewriter): New alias for stamps/rewriter.stamp.
		(rewrite-rhino): Likewise for stamps/rewrite-rhino.stamp.
		* patches/icedtea-rhino.patch:
		Copy rather than symlink the JAR file.  Only drop the
		internal suffix on the javascript package names.
		* rewriter/com/redhat/rewriter/ClassRewriter.java:
		(executor): Use a single threaded executor when
		debugging is enabled.
		(tasks): Store the Futures returned by the executor
		for later checking.
		(main(String[])): Log what happens when processFile
		returns and handle any exceptions using Futures.
		(call()): Ensure srcDir/destDir replacement always
		matches with a trailing slash to avoid odd rewrites.
		Loop directory creation to avoid possible race issues.
		Increase logging and fix a number of issues with the rewrite:
		  * Fix off-by-one loop bug so final entry is inspected.
		  * Handle double entries which occur with 8-byte entries
		    (doubles and longs):
		http://java.sun.com/docs/books/jvms/second_edition/html/ClassFile.doc.html#16628

-- 
You received this bug notification because you are a member of OpenJDK,
which is subscribed to openjdk-6 in Ubuntu.
https://bugs.launchpad.net/bugs/255149

Title:
  javascript script support through rhino should not be on bootclasspath

Status in openbravo:
  Confirmed
Status in OpenJDK:
  Fix Released
Status in openjdk-6 package in Ubuntu:
  Fix Released

Bug description:
  I'm trying to run a custom rhino to build Dojo, but OpenJDK keeps
  ignoring the rhino in the jar file I provide and keeps loading rhino
  from the system libs:

  $ java -verbose:class -jar ../shrinksafe/custom_rhino.jar
  ...
  [Opened /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.tools.shell.Main from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.ContextFactory from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.tools.shell.ShellContextFactory from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  ...

  If I specify a classpath, it still loads from the system rhino
  library:

  $ java -classpath ../shrinksafe/ -verbose:class -jar ../shrinksafe/custom_rhino.jar
  ...
  [Opened /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.tools.shell.Main from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.ContextFactory from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  [Loaded org.mozilla.javascript.tools.shell.ShellContextFactory from /usr/lib/jvm/java-6-openjdk/jre/lib/rhino.jar]
  ...

  If I change over to using sun's JRE, it works fine:

  $ sudo update-java-alternatives --set java-6-sun
  $ java -verbose:class -jar ../shrinksafe/custom_rhino.jar
  ...
  [Loaded org.mozilla.javascript.tools.shell.Main from file:/home/bryan/bzr/dojo/util/shrinksafe/custom_rhino.jar]
  [Loaded org.mozilla.javascript.RhinoException from file:/home/bryan/bzr/dojo/util/shrinksafe/custom_rhino.jar]
  [Loaded org.mozilla.javascript.EvaluatorException from file:/home/bryan/bzr/dojo/util/shrinksafe/custom_rhino.jar]
  ...

To manage notifications about this bug go to:
https://bugs.launchpad.net/openbravo/+bug/255149/+subscriptions


References