openjdk team mailing list archive

[John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>]

Source: openjdk-9
Version: 9~b181-4
Severity: normal
Tags: patch

Hello!

While fixing #871319 someone (me!) sent a patch which accidentally
disabled the Zero builds on the Hotspot architectures because the
patch unset "altzero_archs". The correct fix should have been to
set that variable to "$(hotspot_archs) $(altshark_archs)", hence:

--- debian/rules~       2017-08-24 19:10:11.000000000 +0200
+++ debian/rules        2017-09-04 21:08:29.204400359 +0200
@@ -163,7 +163,7 @@
 # Shark build but just crash
  altshark_archs =

-# altzero_archs = $(filter-out , $(hotspot_archs)) $(altshark_archs)
+altzero_archs = $(hotspot_archs) $(altshark_archs)

 ifeq (,$(filter noaltzero, $(DEB_BUILD_OPTIONS))$(filter noaltshark, $(DEB_BUILD_OPTIONS)))
    ifneq (,$(filter $(DEB_HOST_ARCH), $(altzero_archs)))

Attaching a patch. Please consider applying it for the next upload.

Thanks and sorry for the mistake!

Adrian

--
  .''`.  John Paul Adrian Glaubitz
 : :' :  Debian Developer - glaubitz@xxxxxxxxxx
 `. `'   Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- debian/rules~	2017-08-24 19:10:11.000000000 +0200
+++ debian/rules	2017-09-04 21:08:29.204400359 +0200
@@ -163,7 +163,7 @@
 # Shark build but just crash
 altshark_archs =
 
-# altzero_archs = $(filter-out , $(hotspot_archs)) $(altshark_archs)
+altzero_archs = $(hotspot_archs) $(altshark_archs)
 
 ifeq (,$(filter noaltzero, $(DEB_BUILD_OPTIONS))$(filter noaltshark, $(DEB_BUILD_OPTIONS)))
   ifneq (,$(filter $(DEB_HOST_ARCH), $(altzero_archs)))