← Back to team overview

openjdk team mailing list archive

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

 

Ok Turns out Java has some super funky code:

        int componentState = context.getComponentState();
        if ((componentState & SynthConstants.DISABLED) ==
                              SynthConstants.DISABLED){
            if (!GTKLookAndFeel.is3()) {
                Color orgColor = g.getColor();
                g.setColor(context.getStyle().getColor(context,
                        GTKColorType.WHITE));
                x += 1;
                y += 1;
                super.paintText(context, g, text, x, y, mnemonicIndex);

                g.setColor(orgColor);
                x -= 1;
                y -= 1;
            }
            super.paintText(context, g, text, x, y, mnemonicIndex);
        }


Removing this silly +1 white shadowing nonsense results in perfect looking menus both when dark and light.
I will take this upstream and see if it can be patched into Ubuntu, not a theming bug after all.

-- 
You received this bug notification because you are a member of OpenJDK,
which is subscribed to openjdk-8 in Ubuntu.
https://bugs.launchpad.net/bugs/1729558

Title:
  [regression] In Java apps like Netbeans, dark menu bars don't look
  good for disabled elements

Status in Ubuntu theme:
  Confirmed
Status in openjdk-8 package in Ubuntu:
  Confirmed
Status in ubuntu-themes package in Ubuntu:
  Confirmed

Bug description:
  This fix, #961679, specifically Ambiance/gtk-2.0/gtkrc:346
  (http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-
  themes/trunk/revision/583), makes disabled elements in menus look
  terrible.

  Unfortunately I'm not aware of an easy way to get screenshots of open
  menus, so hopefully these attached phone pictures of Netbeans are
  enough to illustrate the issue.

  As you can see it is hard to tell the difference between what is
  disabled and what isn't, and the disabled items look fuzzy (easier to
  observe on monitor).

  I really don't see the issue with lighter menus, but if they must stay
  dark then the readability / contrast of disabled items needs to be
  fixed.

  Thanks

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-themes/+bug/1729558/+subscriptions