← Back to team overview

openjdk team mailing list archive

Bug#944738: Bug#944738: jlink: Hash of module differs to expected hash recorded in java.base

 

Dear Tony and Tiago,

Pleasure!  Needs forced me to do so ;-)

Best wishes,

   Julian

On Fri, Sep 18, 2020 at 01:13:55PM -0300, Tiago Daitx wrote:
> Hi Tony,
> 
> Matthias is the actual Debian Maintainer, but in my opinion the patch
> is great and should be ok to go do an upload including it.
> 
> Thanks Julian for the investigation and figuring out how to fix this
> problem, I really appreciate it. =)
> 
> Best regards,
> Tiago
> 
> On Fri, Sep 18, 2020 at 11:12 AM tony mancill <tmancill@xxxxxxxxxx> wrote:
> >
> > On Fri, Sep 18, 2020 at 11:15:13AM +0100, Julian Gilbey wrote:
> > > tags 944738 patch
> > > thanks
> > >
> > > On Thu, Sep 17, 2020 at 06:45:39PM +0100, Julian Gilbey wrote:
> > > > affects 944738 openjdk-14-jdk
> > > > thanks
> > > >
> > > > The same problem is still present in openjdk-14 - see
> > > > https://bugs.debian.org/968991
> > >
> > > I have located the source of the bug and have a patch to fix it.
> > >
> > > The cause is the use of dh_strip_nondeterminism late in the build
> > > process.  This reorganises the jmod files, which in turn changes their
> > > SHA256 checksums.  This would not be a problem, except that the
> > > checksums are saved in java.base.jmod *before* the use of
> > > dh_strip_nondeterminism.  Performing this stripping immediately after
> > > each jmod file is created results in the checksums being consistent
> > > throughout.
> >
> > Thank you for digging into this bug Julian!
> >
> > Matthias or Tiago, any concerns with me preparing an upload that
> > includes this patch?
> >
> > Thank you,
> > tony


References