openjdk team mailing list archive

[Julian Gilbey <jdg@xxxxxxxxxx>]

On Mon, Sep 21, 2020 at 07:03:08AM -0700, tony mancill wrote:
> On Mon, Sep 21, 2020 at 10:01:35AM +0100, Julian Gilbey wrote:
> > On Sun, Sep 20, 2020 at 09:59:22PM -0700, tony mancill wrote:
> > > Hi Tiago, hi Julian,
> > > [...]
> > > Julian, I applied the patch and built the package successfully, but
> > > jlink still fails with the "expected hash" error.  It's (perhaps)
> > > interesting that the expected hash does differ between the patched build
> > > and the unpatched build.
> > 
> > That's really bizarre.  I checked running strip-nondeterminism on the
> > resulting jmods and it seemed to be OK.  But if so, then I've clearly
> > overlooked something.
> 
> I'm wondering if we just need more of it sprinkled about earlier in the
> build.  I didn't believe it at first and so rebuilt (more than once) to
> be sure.

Hi Tony,

Here are a couple more thoughts on exploring this:

* Search through the build log to check that strip-nondeterminism is
  actually being called.  If it's not, perhaps the patch has
  accidentally not been applied.

* Run the sha256sum command (protected with a '-' in case it fails!)
  at several points in the build-arch and install targets to see when
  the hashes change, if at all.

HTH,

   Julian