← Back to team overview

openjdk team mailing list archive

[Bug 2011653] [NEW] Please drop obsolete patches

 

Public bug reported:

Please drop following patches:
- workaround_expand_exec_shield_cs_limit.diff
This patch enables code in workaround_expand_exec_shield_cs_limit() for IA32 and not Zero VM: '#if defined(IA32) && !defined(ZERO)'
workaround_expand_exec_shield_cs_limit() is called from src/hotspot/os/linux/os_linux.cpp:5515 which already has `#if defined(IA32) && !defined(ZERO)`
Notice, that Hotspot-disable-exec-shield-workaround.diff fully disables this method, making the patch obsolete.

- Generated-headers.patch
This patch adds include path -I/<<PKGBUILDDIR>>/build/support/headers/java.desktop which is already added by the build

- Parallel-build-fix.diff
This patch updates make/hotspot/gensrc/GensrcJfr.gmk to include target directory for generated JNI includes for BUILD_JFR_TOOLS.
The tool is built from make/src/classes/GenerateJfrFiles which does not contain any native methods.
The added path is unnecessary.

** Affects: openjdk-17 (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: openjdk-20 (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: openjdk-lts (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: lunar

** Also affects: openjdk-17 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: openjdk-20 (Ubuntu)
   Importance: Undecided
       Status: New

** Description changed:

  Please drop following patches:
  - workaround_expand_exec_shield_cs_limit.diff
  This patch enables code in workaround_expand_exec_shield_cs_limit() for IA32 and not Zero VM: '#if defined(IA32) && !defined(ZERO)'
- This function  is called from src/hotspot/os/linux/os_linux.cpp:5515 which already has `#if defined(IA32) && !defined(ZERO)`
+ workaround_expand_exec_shield_cs_limit() is called from src/hotspot/os/linux/os_linux.cpp:5515 which already has `#if defined(IA32) && !defined(ZERO)`
  Notice, that Hotspot-disable-exec-shield-workaround.diff fully disables this method, making the patch obsolete.
  
  - Generated-headers.patch
  This patch adds include path -I/<<PKGBUILDDIR>>/build/support/headers/java.desktop which is already added by the build
  
  - Parallel-build-fix.diff
- This patch updates make/hotspot/gensrc/GensrcJfr.gmk to include target directory for generated JNI includes for BUILD_JFR_TOOLS. 
+ This patch updates make/hotspot/gensrc/GensrcJfr.gmk to include target directory for generated JNI includes for BUILD_JFR_TOOLS.
  The tool is built from make/src/classes/GenerateJfrFiles which does not contain any native methods.
  The added path is unnecessary.

** Tags added: lunar

-- 
You received this bug notification because you are a member of OpenJDK,
which is subscribed to openjdk-lts in Ubuntu.
https://bugs.launchpad.net/bugs/2011653

Title:
  Please drop obsolete patches

Status in openjdk-17 package in Ubuntu:
  New
Status in openjdk-20 package in Ubuntu:
  New
Status in openjdk-lts package in Ubuntu:
  New

Bug description:
  Please drop following patches:
  - workaround_expand_exec_shield_cs_limit.diff
  This patch enables code in workaround_expand_exec_shield_cs_limit() for IA32 and not Zero VM: '#if defined(IA32) && !defined(ZERO)'
  workaround_expand_exec_shield_cs_limit() is called from src/hotspot/os/linux/os_linux.cpp:5515 which already has `#if defined(IA32) && !defined(ZERO)`
  Notice, that Hotspot-disable-exec-shield-workaround.diff fully disables this method, making the patch obsolete.

  - Generated-headers.patch
  This patch adds include path -I/<<PKGBUILDDIR>>/build/support/headers/java.desktop which is already added by the build

  - Parallel-build-fix.diff
  This patch updates make/hotspot/gensrc/GensrcJfr.gmk to include target directory for generated JNI includes for BUILD_JFR_TOOLS.
  The tool is built from make/src/classes/GenerateJfrFiles which does not contain any native methods.
  The added path is unnecessary.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openjdk-17/+bug/2011653/+subscriptions



Follow ups