openlp-android team mailing list archive

[Johan Mynhardt <johanmynhardt@xxxxxxxxx>]

> 1359    + List<String> result1 = new ArrayList<String>();
> 1360    + returnString = "";
> 1361    +
> 1362    + for (int i = 0; i < items.length(); i++) {
> 1363    + result1.add(items.getJSONObject(i).getString("title"));
> 1364    + }
> 1365    +
> 1366    + instream.close();
> 1367    + publishProgress(result1);
> 
> All examples I have found is the publishProgress takes a String not an array
> string.  So this may be the warning.
> As a side note a colleague warned against using Genetics too freely as they
> may have a performance issue.
> Do we want to publish a single list of Titles? Should this not be in the loop?

I did move it into the loop and tested it, but it was slower/took longer to finish the task.
On the Generics: I don't see why generics should be avoided since it seems that android's API's use it rather extensively.
-- 
https://code.launchpad.net/~johanmynhardt/openlp/android/+merge/59710
Your team OpenLP Android Developers is subscribed to branch lp:openlp/android.