← Back to team overview

openlp-android team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/android_05 into lp:openlp/android

To: mp+106445@xxxxxxxxxxxxxxxxxx
From: Johan Mynhardt <johanmynhardt@xxxxxxxxx>
Date: Fri, 18 May 2012 19:58:10 -0000
In-reply-to: <20120518181022.4027.37490.launchpad@ackee.canonical.com>
Reply-to: mp+106445@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks great!

Not sure if I should mark as needs fixing for line 49... Marking as Approve anyhow.

(Might be a matter of preference, but doing full imports causes less confusion later on)
-- 
https://code.launchpad.net/~trb143/openlp/android_05/+merge/106445
Your team OpenLP Android Developers is subscribed to branch lp:openlp/android.

References

[Merge] lp:~trb143/openlp/android_05 into lp:openlp/android
From: Tim Bentley, 2012-05-18