← Back to team overview

openlp-android team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/android-2 into lp:openlp/android

To: mp+157543@xxxxxxxxxxxxxxxxxx
From: Johan Mynhardt <johanmynhardt@xxxxxxxxx>
Date: Sun, 07 Apr 2013 17:06:19 -0000
In-reply-to: <20130407122819.5746.67661.launchpad@ackee.canonical.com>
Reply-to: mp+157543@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Looks good to me! Although it appears that in several places the indents have been replaced with spaces. I'm not 100% sure of the convention, but most places I looked, it seems that the indents are achieved by means of tabs.
-- 
https://code.launchpad.net/~trb143/openlp/android-2/+merge/157543
Your team OpenLP Android Developers is subscribed to branch lp:openlp/android.

References

[Merge] lp:~trb143/openlp/android-2 into lp:openlp/android
From: Tim Bentley, 2013-04-07