openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Approve
If you can compress the opening and reading of a file into "open(filename).read()" what is the need for the "fileToXML" method?

What's the need for two theme XML classes? I would suggest having a single ThemeXML class which has a "build()" and a "parse()" method.

Also just remember that when you're passing named parameters in a method, you don't need spaces between the parameter name and the value:
e.g.

  self.do_method(parameter=value)
-- 
https://code.launchpad.net/~trb143/openlp/ThemeManager/+merge/5233
Your team openlp.org Core is subscribed to branch lp:openlp.