← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/ThemeManager2 into lp:openlp

 

Review: Approve
If you wanted to, you could make the __init__ function of ThemeXML take named parameters so that it's a little cooler, like so:

  theme = ThemeXML(parse=theme_xml)

It would cut 2 lines down to 1. Just a nice-to-have though.
-- 
https://code.launchpad.net/~trb143/openlp/ThemeManager2/+merge/5302
Your team openlp.org Core is subscribed to branch lp:openlp.



References