openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

> I would rather write convertStringToBoolean() like this:
> 
>     return stringvalue.lower() in ('true', 'on', 'yes', 'y')
> 
> +        words=words.replace(u'\r\n', u'\n')
> +        verses_text = words.split(u'\n')
> 
> Rather use words.splitlines().
> 

That's probably my historical code - sorry!

> +        import time
> 
> Any reason why that's not imported at the top of the file?
> 

Probably not needed at all actually (again my fault - comes from timing some bits of render code IIRC)

-- 
https://code.launchpad.net/~trb143/openlp/ThemeManager2/+merge/5894
Your team openlp.org Core is subscribed to branch lp:openlp.