openlp-core team mailing list archive

[Michael Gorven <michael@xxxxxxxxxxxxx>]

Review: Approve
+        if self.VerseListView.count() == 0:    # must have 1 slide
+            invalid += 1
+
         if invalid == 1:
             self.valid = False

Any reason that you don't set self.valid directly instead of using invalid? If 
there is a reason, please change the check to be "invalid != 0".

+        if override == u'True':

Maybe use the convertStringToBoolean() function instead.

 review approve

-- 
https://code.launchpad.net/~trb143/openlp/ThemeManager2/+merge/6073
Your team openlp.org Core is subscribed to branch lp:openlp.