openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

Review: Approve
I'm not sure it's too pythonic to have code in __init__.py, but I don;t think it's a hard and fast rule...

Other than that, I don't know enough about Qt events to do more than nit-pick thus:

        def onImageAddClick(self):
818	- """Add this item to the OOS"""
819	- pass
820	+ log.debug(u'Image Live Requested')

Should be "Image Add Requested"?

Also, in handle_event() in imageplugin, customplugin, bibleplugin - there's some log calls which don;t match the event (they all say "LoadServiceItem")

I guess at some point, we should make the size of the previews configurable (or otherwise intelligent based on screen size?)  Or mousewheel zoomable?



-- 
https://code.launchpad.net/~trb143/openlp/servicing/+merge/6589
Your team openlp.org Core is subscribed to branch lp:openlp.