← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/servicing into lp:openlp

 

Review: Approve
Two or three of suggestions:

Line 147
    - Does it need to be MediaMediaItem - looks a bit weird? 
    - Also, should be Select Media item(s)'  - the (s) in the wrong place :)
Line 149 
   - should be something like self.parent.config.get_last_dir(), u'Media Files (*.avi *.mpeg)')... do we need more file extensions (or sets of) in here, for audio, and other video?  And a *.* option?
line 271 
   - MediaMediaItem as well
and line 297

-- 
https://code.launchpad.net/~trb143/openlp/servicing/+merge/6619
Your team openlp.org Core is subscribed to branch lp:openlp.



References