openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #00092
Re: [Merge] lp:~trb143/openlp/servicing into lp:openlp
Review: Approve
Looks fine. Just 2 things though.
Firstly, coding standards - but I understand that this is "legacy" code, so that's fine.
Secondly, if you're working on the songs plugin, rather create a new branch off trunk with an appropriate name (like "songsplugin"). It's the reason we went with Bazaar :-)
--
https://code.launchpad.net/~trb143/openlp/servicing/+merge/7089
Your team openlp.org Core is subscribed to branch lp:openlp.
References