openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

Review: Approve
Small (or even tiny :) comments:
Line 241 of the merge, I personally would be happy with the comment on the same line as the code
Line 251,252 - could the function calls be named a bit more descriptively, then no extra comments would be reqd?
Line 291, 'OSIS' has no "u" in front of it...
Line 686: the second string has no u in front of it.

-- 
https://code.launchpad.net/~trb143/openlp/bugfixes/+merge/7167
Your team openlp.org Core is subscribed to branch lp:openlp.