openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Approve
These seem to be commented out, so they're not "break" but it would be nice if they were corrected:

openlp/core/lib/eventreceiver.py
61       Receiver().send_message(u'messageid",data)
                                           ^^^
61       Receiver().send_message(u'messageid', data)

openlp/core/lib/pluginconfig.py
85       #suffix = self.get_config(u'suffix name", default_suffixes)
                                               ^^^
85       #suffix = self.get_config(u'suffix name', default_suffixes)


You missed one (or more)!

openlp/core/lib/rendermanager.py
171     if event == "line":
173	         filename = frame.f_globals["__file__"]
179	         name = frame.f_globals["__name__"]
183	             print "%s:%s: %s" % (name, lineno, line.rstrip()) # do we need the print?

openlp/core/test/test_mediamanageritem.py
252        logging.info (u'App is " + unicode(self.app))
277        log.info(u'i1"+unicode(i1))
278        log.info(u'i2"+unicode(i2))
281        i1.addToolbarButton(u'Test1", u'Test1", None)
287        i2.addToolbarButton(u'Test2", u'Test2", None)
288        self.MediaToolBox.setItemText(self.MediaToolBox.indexOf(i1), translate(u'main_window", u'Item1"))
289        self.MediaToolBox.setItemText(self.MediaToolBox.indexOf(i2), translate(u'main_window", u'Item2"))
296	 if __name__=="__main__":

openlp/core/test/test_plugin_manager.py
342        assert (u'testplugin1" in names)
343        assert (u'testplugin2" in names)
346        assert (u'testplugin3" not in names)
348	         assert p.plugins[0].name=="testplugin2"
349	         assert p.plugins[1].name=="testplugin1"
350	 if __name__=="__main__":
359        log.debug(u'Plugin %s, name=%s (version=%d)"%(unicode(plugin), plugin.name, plugin.version))

(plus a bunch more in other test classes)


For future reference, rather put the comment on the line before this one:

openlp/core/lib/rendermanager.py
191        self.footer_start = int(self.height*0.90) # 90% is start of footer


-- 
https://code.launchpad.net/~trb143/openlp/songs/+merge/7514
Your team openlp.org Core is subscribed to branch lp:openlp.