openlp-core team mailing list archive

[ALok <thealok@xxxxxxxxx>]

So what do I have to do to add this fix? Should I push up a new
revision? And then do I need to do a new merge proposal?

On Wed, Jul 22, 2009 at 1:19 AM, Raoul
Snyman<raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Review: Needs Fixing
> Just one thing...
>
> 42      if self.author == None:
>
> should read:
>
> 42      if self.author is None:
>
> There is a small, but significant, difference between == and is when it comes to None.
> --
> https://code.launchpad.net/~thealok/openlp/authorform/+merge/9118
> You are the owner of lp:~thealok/openlp/authorform.
>



-- 
A
https://code.launchpad.net/~thealok/openlp/authorform/+merge/9118
Your team openlp.org Core is subscribed to branch lp:openlp.