openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

To: Jon Tibble <meths@xxxxxxxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Mon, 07 Sep 2009 04:36:51 -0000
In-reply-to: <20090907023021.1106.40713.launchpad@loganberry.canonical.com>
Reply-to: mp+11282@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Looks good but the diff makes it difficult to see what has changed in the themes area.
In response to your question about themes being loaded in one place then yes is the answer.

The needs fixing is due to your changes to save UI.

SettingsManager is the place where this should be triggered from.  I changed it in the last merger to try and get the screen size consistent.
It should save and load settings and control how the UI looks.
Also each time something is changes it should be saved.

Have a look at ServiceManager for saving and loading settings in configuration.  The Theme Combo on the toolbar is loaded and saved when needed.

-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11282
Your team openlp.org Core is subscribed to branch lp:openlp.

References

[Merge] lp:~meths/openlp/trivialfixes into lp:openlp
From: Jon Tibble, 2009-09-07