openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.

Requested reviews:
    openlp.org Core (openlp-core)

Make sure network code is not run if plugin is not needed.

Add ``weight`` desciption to plugin documentation
-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11328
Your team openlp.org Core is subscribed to branch lp:openlp.

=== modified file 'openlp/core/lib/plugin.py'
--- openlp/core/lib/plugin.py	2009-09-06 18:59:21 +0000
+++ openlp/core/lib/plugin.py	2009-09-07 20:39:17 +0000
@@ -45,6 +45,9 @@
     ``log``
         A log object used to log debugging messages. This is pre-instantiated.
 
+    ``weight``
+        A numerical value used to order the plugins.
+
     **Hook Functions**
 
     ``check_pre_conditions()``

=== modified file 'openlp/plugins/remotes/remoteplugin.py'
--- openlp/plugins/remotes/remoteplugin.py	2009-09-07 19:00:24 +0000
+++ openlp/plugins/remotes/remoteplugin.py	2009-09-07 20:39:17 +0000
@@ -35,10 +35,6 @@
         # Call the parent constructor
         Plugin.__init__(self, u'Remotes', u'1.9.0', plugin_helpers)
         self.weight = -1
-        self.server = QtNetwork.QUdpSocket()
-        self.server.bind(int(self.config.get_config(u'remote port', 4316)))
-        QtCore.QObject.connect(self.server,
-            QtCore.SIGNAL(u'readyRead()'), self.readData)
 
     def check_pre_conditions(self):
         """
@@ -51,6 +47,12 @@
         else:
             return False
 
+    def initialise(self):
+        self.server = QtNetwork.QUdpSocket()
+        self.server.bind(int(self.config.get_config(u'remote port', 4316)))
+        QtCore.QObject.connect(self.server,
+            QtCore.SIGNAL(u'readyRead()'), seld.readData)
+
     def get_settings_tab(self):
         """
         Create the settings Tab