openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

Review: Approve
Approve.

Some stylistic comments:

Various line splits happen within translate() call
	 self.Toolbar.addToolbarButton(u'New Service',
	u':/services/service_new.png', translate(u'ServiceManager',
	u'Create a new Service'), self.onNewService)

might be better as
	 self.Toolbar.addToolbarButton(u'New Service',
	u':/services/service_new.png', 
        translate(u'ServiceManager',u'Create a new Service'), self.onNewService)

(in various other places)
Line 38 - personally I prefer ()s around items rather than \s for line continuation

I wouldn't split 51, 81 

Line 102 should be os.path.join()

Line 138, split at u'order', rather than in the len( call

Personally I wouldn't split 163,172,182 either...
-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11549
Your team openlp.org Core is subscribed to branch lp:openlp.