openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
Please rename your addHeaderBar functions. I can see two options...

1. Have a single function, named "addHeaderBar", that takes a single parameter, "HeaderBarType" which can be either "HeaderBarType.Start" or "HeaderBarType.End";

2. Have two separate functions, named "addStartHeaderBar" and "addEndHeaderBar"
-- 
https://code.launchpad.net/~trb143/openlp/bugfixes/+merge/11581
Your team openlp.org Core is subscribed to branch lp:openlp.