openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

Review: Approve
Wow - that's a big patch :)

I'll put my suggestions for translations on a mail for further discussion...

The NotImplementedErrors also look a bit weird - I'd prefer to change the 80-col rule for those (or exceptions in general..?)


On a different note:
1021	+ self.auditFile.write(u'\"%s\",\"%s\",\"%s\",\"%s\"\n' % \
1022	+ (date.today(), auditData[0], author, auditData[2]))
Do the "s need a \ - given that the surrounding quotes are single 's?

1970	+import os , subprocess
no space after os.


-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12190
Your team openlp.org Core is subscribed to branch lp:openlp.