← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/bitsandbobs into lp:openlp

 

Review: Needs Fixing
Two things...

Firstly, is there a reason for a whole object to check the latest version? Why not just put
a "check_version" function in the utils/__init__.py file?

Secondly, our coding standards say that only Qt-derivative classes should use camelCase method names. For all pure-Python objects, we use under_score method names.
-- 
https://code.launchpad.net/~trb143/openlp/bitsandbobs/+merge/13188
Your team OpenLP Core is subscribed to branch lp:openlp.



Follow ups

References