openlp-core team mailing list archive

[Martin Thompson <mjthompson@xxxxxxx>]

Review: Approve
A couple of nitpicks (possibly unrelated to the actual changes, but there nontheless?):

81: double quoted string with no u''s
86: cmd = sqliteexe + u' "' + olddb + u'" .dump'
might be better as 
  cmd= u'%s  "%s" .dump' % (sqliteexe, olddb)
Line 99 is similar.

88 and 90, the 'w's - need a u in front of them
101,103 the 'r'  need a u in front
116 has a double-quoted string with no u'' s



-- 
https://code.launchpad.net/~j-corwin/openlp/migration/+merge/13537
Your team OpenLP Core is subscribed to branch lp:openlp.