openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing 
Your "fix" for no slide is still going to break.

    if self.serviceItem and self.serviceItem.is_command():
        Receiver.send_message(u'%s_last'% self.serviceItem.name.lower())
        self.updatePreview()
    else:
        ...
        # This code will be executed instead

Rather do this (which I've actually just done in my bitsandbobs branch anyways):

    if not set.serviceItem:
        return

-- 
https://code.launchpad.net/~trb143/openlp/songediting/+merge/15440
Your team OpenLP Core is subscribed to branch lp:openlp.