openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
This presumes that icon is a list-type. If it's not, it'll break.

    if len(icon) > 2:

Please remove this line from resources.py when you regenerate it:

    qInitResources()

Don't forget to remove the re-add the copyright notice after regenerating the form file.

    # Form implementation generated from reading ui file 'editversedialog.ui'
    #
    # Created: Wed Dec 2 08:14:47 2009
    # by: PyQt4 UI code generator 4.6.2
    #
    # WARNING! All changes made in this file will be lost!

Your verse type detection code is case sensitive. This is going to confuse people.

-- 
https://code.launchpad.net/~trb143/openlp/songediting/+merge/15666
Your team OpenLP Core is subscribed to branch lp:openlp.