openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
35	=== modified file 'openlp/plugins/songs/lib/sofimport.py'
36	--- openlp/plugins/songs/lib/sofimport.py 2010-04-02 14:10:10 +0000
37	+++ openlp/plugins/songs/lib/sofimport.py 2010-04-03 22:19:13 +0000
38	@@ -1,4 +1,4 @@
39	-# -*- coding: utf-8 -*-
40	+property# -*- coding: utf-8 -*-

Oops, just fix that so that we don't forget about it please?


19	+ del_message = self.trUtf8('Delete %d song?' % len(items))

Don't do that. That way the number is sent for translation as well, and then the string is only translated when the number is "2" (for instance). Rather do this:

19	+ del_message = unicode(self.trUtf8('Delete %d song?')) % len(items)


20	+ ans = QtGui.QMessageBox.question(None,

Since you're in the media manager item, set the message box's parent to the media manager item...

20	+ ans = QtGui.QMessageBox.question(self,



-- 
https://code.launchpad.net/~j-corwin/openlp/sof/+merge/22767
Your team OpenLP Core is subscribed to branch lp:openlp.