openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
6 self.remoteTriggered = None
7 self.ServiceItemIconName = None
8 self.single_service_item = True
9 self.addToServiceItem = False

Is this a Qt class, or a Python class?


100 if serviceItem[u'service_item'].\
101     is_capable(ItemCapabilities.AllowsMaintain):

Just a style preference, I prefer to put the . on the next line, it helps you see that the following line is part of the previous line:

100 if serviceItem[u'service_item']\
101     .is_capable(ItemCapabilities.AllowsMaintain):

-- 
https://code.launchpad.net/~trb143/openlp/bugs1/+merge/22896
Your team OpenLP Core is subscribed to branch lp:openlp.