openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Too late to reject but:
965	+            Receiver.send_message(u'presentation_blank')

1. It should be 'presentations_blank'. 
2. Core should not have anything plugin specific
3. What was wrong with the plugin-generic...

1006	-                Receiver.send_message(
1007	-                    u'%s_blank' % self.serviceItem.name.lower(),
1008	-                    [self.serviceItem, self.isLive])

This would still send 'presentations_blank' signal if a presentation is live, but without hard-coding presentations, and would work going forwards for other 'command' type plugins in the future.
-- 
https://code.launchpad.net/~trb143/openlp/working/+merge/24502
Your team OpenLP Core is subscribed to branch lp:openlp.