openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing
Get in before Jon... 

   if bible is not None: 

could be replaced with just:

   if bible:

Also the coding standards say inline comments should be two spaces from statement (although personally I'd put them on their own line in the except: but I don't know what the consensus is here, but standards do say use sparingly)

 try: # WindowsStaysOnBottomHint is not available in QT4.4

-- 
https://code.launchpad.net/~mjthompson/openlp/qt4.4/+merge/24931
Your team OpenLP Core is subscribed to branch lp:openlp.