← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mjthompson/openlp/qt4.4 into lp:openlp

To: Martin Thompson <martin@xxxxxxxxxxxxxxxxxx>
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 09 May 2010 19:52:24 -0000
In-reply-to: <20100507203925.24111.8397.launchpad@loganberry.canonical.com>
Reply-to: mp+24931@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Hrm... I'm not sure that folks would have a Bible named "" - if you know of one, please enlighten us :-P

As for comments, while inline comments are fine, I prefer putting comments on their own line.

Otherwise, it all looks fine to me.
-- 
https://code.launchpad.net/~mjthompson/openlp/qt4.4/+merge/24931
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mjthompson/openlp/qt4.4 into lp:openlp
From: Martin Thompson, 2010-05-07