openlp-core team mailing list archive

[Martin Thompson <martin@xxxxxxxxxxxxxxxxxx>]

Martin Thompson has proposed merging lp:~mjthompson/openlp/monitor_check into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)


Not sure if this is a "correct" change - it stops the crash!  Should self.override be a copy of self.current when the selected monitor is > number of screens, or just have self.current assigned to it?
-- 
https://code.launchpad.net/~mjthompson/openlp/monitor_check/+merge/25186
Your team OpenLP Core is requested to review the proposed merge of lp:~mjthompson/openlp/monitor_check into lp:openlp.

=== modified file 'openlp/core/ui/screen.py'
--- openlp/core/ui/screen.py	2010-04-28 16:41:04 +0000
+++ openlp/core/ui/screen.py	2010-05-12 20:47:24 +0000
@@ -61,9 +61,10 @@
         """
         Set up the current screen dimensions
         """
-        log.debug(u'set_override_display %s', number, )
+        log.debug(u'set_current_display %s', number, )
         if number + 1 > self.display_count:
             self.current = self.screen_list[0]
+            self.override = copy.deepcopy(self.current)
             self.current_display = 0
         else:
             self.current = self.screen_list[number]