← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #01611

Re: [Merge] lp:~trb143/openlp/working into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Approve approve
Looks good. One remark: You've used "verseTag" as a stand-alone variable. I know it's in a Qt derived class, but it's a Python variable, I'd prefer it to be "verse_tag".
-- 
https://code.launchpad.net/~trb143/openlp/working/+merge/25849
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next