openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~crichter/openlp/i18n into lp:openlp

To: rimach <crichter@xxxxxx>
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 27 May 2010 07:16:24 -0000
In-reply-to: <20100527065628.18847.60740.launchpad@loganberry.canonical.com>
Reply-to: mp+26126@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
I agree with Tim, we shouldn't use "getter" methods, the variable is right there. In fact, you're using the get_display_name() over the MediaItem's title, which I think should be translatable itself.

As I mentioned previously in IRC, we should rather set a self.display_name variable in the constructor of the plugin, and make it translatable right there.

You have the right idea, we just need to implement it in a different way.
-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/26126
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~crichter/openlp/i18n into lp:openlp
From: rimach, 2010-05-27