openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

Review: Needs Fixing
In servicemanager starting at diff line 141 and thememanager starting at diff line 267 the error logic allows the new try to fail while still trying to read the file afterwards even though ucsfile will not have been defined.  So the outer try excepts on diff lines 197 and 302 need to except NameError too.

Typo in 149 and 274 should be "is not"


-- 
https://code.launchpad.net/~m2j/openlp/work/+merge/27213
Your team OpenLP Core is subscribed to branch lp:openlp.