openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)


Fix check_item_selection
-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/28448
Your team OpenLP Core is requested to review the proposed merge of lp:~meths/openlp/trivialfixes into lp:openlp.

=== modified file 'openlp/core/lib/__init__.py'
--- openlp/core/lib/__init__.py	2010-06-24 15:50:40 +0000
+++ openlp/core/lib/__init__.py	2010-06-24 19:38:37 +0000
@@ -170,7 +170,7 @@
         The message to give the user if no item is selected
     """
     if not list_widget.selectedIndexes():
-        QtGui.QMessageBox.information(self,
+        QtGui.QMessageBox.information(list_widget.parent(),
             translate('MediaManagerItem', 'No Items Selected'), message)
         return False
     return True

=== modified file 'openlp/core/lib/baselistwithdnd.py'
--- openlp/core/lib/baselistwithdnd.py	2010-04-30 21:00:17 +0000
+++ openlp/core/lib/baselistwithdnd.py	2010-06-24 19:38:37 +0000
@@ -32,7 +32,6 @@
 
     def __init__(self, parent=None):
         QtGui.QListWidget.__init__(self, parent)
-        self.parent = parent
         # this must be set by the class which is inheriting
         assert(self.PluginName)
 

=== modified file 'openlp/plugins/bibles/lib/mediaitem.py'
--- openlp/plugins/bibles/lib/mediaitem.py	2010-06-21 18:28:36 +0000
+++ openlp/plugins/bibles/lib/mediaitem.py	2010-06-24 19:38:37 +0000
@@ -43,7 +43,8 @@
         BaseListWithDnD.__init__(self, parent)
 
     def resizeEvent(self, event):
-        self.parent.onListViewResize(event.size().width(), event.size().width())
+        self.parent().onListViewResize(event.size().width(),
+            event.size().width())
 
 
 class BibleMediaItem(MediaManagerItem):