openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Approve approve
This is fine,

if order_by_ref:
    return self.session.query(object_class).filter(filter_clause) \
        .order_by(order_by_ref).all()
return self.session.query(object_class).filter(filter_clause).all()

but you can rewrite the above like so:

query = self.session.query(object_class).filter(filter_clause)
if order_by_ref:
    query = query.order_by(order_by_ref)
return query.all()
-- 
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/28942
Your team OpenLP Core is subscribed to branch lp:openlp.