← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

 

On Sat, Jul 03, 2010 at 02:22:22PM -0000 or thereabouts, Jon Tibble wrote:
> class OpenSongImport(object)
> 
> What, if anything, does this patch set have to do with the OpenSong stuff in songs/lib/songxml.py?  Should this patch also remove/refactor that?

Doh!  Somehow I'd completely missed that code - sorry!

Does anyone know how well tested that code is?  It should certainly be
either refactored into the structure this patch is in (to match the
SOF import) or removed.  I'll have a look at it...  (And then I think
the plan is to refactor all the importers into a structure like the
Bible ones)

Cheers,
Martin
-- 
https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/29148
Your team OpenLP Core is requested to review the proposed merge of lp:~mjthompson/openlp/opensong_import into lp:openlp.



References