openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
I know this isn't your code, but rather catch it now... The <video> tag's attributes are incorrect:

40	+ <video id="video" src="%s"
41	+     autoplay loop width="%s" height="%s"
42	+     autobuffer="autobuffer" preload >
43	+     your browser does not support the video tag
44	+ </video>

should read:

<video id="video" src="%s" autoplay="autoplay" loop="loop" width="%s" height="%s" autobuffer="autobuffer" preload="preload">your browser does not support the video tag</video>

I'm also not sure we actually need the text in there, since this is not a web browser, so it could look like this:

<video id="video" src="%s" autoplay="autoplay" loop="loop" width="%s" height="%s" autobuffer="autobuffer" preload="preload" />

-- 
https://code.launchpad.net/~phill-ridout/openlp/fixes/+merge/29153
Your team OpenLP Core is subscribed to branch lp:openlp.