openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

To: Martin Thompson <martin@xxxxxxxxxxxxxxxxxx>
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Wed, 07 Jul 2010 20:55:58 -0000
In-reply-to: <20100707202841.29701.37164.launchpad@loganberry.canonical.com>
Reply-to: mp+29420@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Comment lines 104, 111, 136 are too long.

Missing spaces around operators on lines: 217, 226, 239, 258

In songimport, you've replaced property ccli_number with song_cclino, yet created a set_ccli_number method which sets ccli_number. Is this correct?

Do we want the test routines in trunk? They are generally forgotten about and I think a load of such routines were previously deleted. Also a few missing spaces around ='s in these.
-- 
https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/29420
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp
From: Martin Thompson, 2010-07-07