openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
Indents have been removed 236-248 etc. against standards

Lines 40 - 93 Nice idea but why could the filter not be done by the database.
                verses = self.session.query(Verse)\
                    .filter_by(book_id=db_book.id)\
                    .filter_by(chapter=chapter)\
                    .filter(Verse.verse >= start_verse)\
                    .filter(Verse.verse <= end_verse)\
                    .order_by(Verse.verse)\
                    .all()
Does a complex search.  It will be much better and if necessary index can be added.
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/29642
Your team OpenLP Core is subscribed to branch lp:openlp.