← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

To: mp+30179@xxxxxxxxxxxxxxxxxx
From: Jon Tibble <meths@xxxxxxxxxxxxxx>
Date: Sat, 17 Jul 2010 16:35:48 -0000
In-reply-to: <20100717160844.11907.78534.launchpad@loganberry.canonical.com>
Reply-to: mp+30179@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
You're breaking the abstraction adding those DB mappings.  You should be using topics = song.topics and for topic in topics, etc.  All the info is already there.

if new_author in song.authors
if new_topic in song.topics
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/30179
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/trivial into lp:openlp
From: googol, 2010-07-17