openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

I'm with Jonathan.  It actually reduces the difference between the selected and unselected tab.  Having looked more closely at the current design to compare to this now, the current design makes the unselected tabs very dark so they don't really fit in with the rest of the app.

How about the diff (against trunk) below (not sure why we should swap selected and non-selected over, just seems to create a bigger diff but just following the example):

=== modified file 'openlp/core/ui/mainwindow.py'
--- openlp/core/ui/mainwindow.py        2010-07-19 07:54:22 +0000
+++ openlp/core/ui/mainwindow.py        2010-07-22 10:07:27 +0000
@@ -39,20 +39,20 @@
 log = logging.getLogger(__name__)

 MEDIA_MANAGER_STYLE = """
+  QToolBox::tab:selected {
+    background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
+        stop: 0 palette(light), stop: 0.5 palette(midlight),
+        stop: 1.0 palette(dark));
+    border: 1px groove palette(dark);
+  }
   QToolBox::tab {
     background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
-        stop: 0 palette(button), stop: 1.0 palette(dark));
-    border-width: 1px;
-    border-style: outset;
-    border-color: palette(dark);
-    border-radius: 5px;
-  }
-  QToolBox::tab:selected {
-    background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
-        stop: 0 palette(light), stop: 1.0 palette(button));
-    border-color: palette(button);
+        stop: 0 palette(button), stop: 0.5 palette(button),
+        stop: 1.0 palette(mid));
+    border-radius: 6px;
   }
 """
+
 class VersionThread(QtCore.QThread):
     """
     A special Qt thread class to fetch the version of OpenLP from the website.

-- 
https://code.launchpad.net/~raoul-snyman/openlp/ui-tweaks/+merge/30585
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/ui-tweaks into lp:openlp.