← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bugfixes into lp:openlp

To: mp+31566@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Mon, 02 Aug 2010 18:44:43 -0000
In-reply-to: <20100802175841.5293.95883.launchpad@loganberry.canonical.com>
Reply-to: mp+31566@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Core should not know or do anything plugin specific, so having a routine with the name usage isn't correct. Usage plugin should be listening for an existing signal instead, and then checking if the live item is a song.
-- 
https://code.launchpad.net/~trb143/openlp/bugfixes/+merge/31566
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/bugfixes into lp:openlp
From: Tim Bentley, 2010-08-02