openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
Please don't add .directory files. If you need to add additional files to bzr, add them on a per-file basis.

Your docstring needs to be in reStructuredText format. See http://sphinx.pocoo.org/rest.html for details.

Your constructure needs a kwargs argument, which is a dict containing keyword arguments:
    def __init__(self, manager, **kwargs)

Your do_import function should not take any parameters.

Your class should inherit from SongImport.

Don't bother adding the menu entries, I'm about to merge the wizard, which renders those unnecessary.
-- 
https://code.launchpad.net/~derek-scotney/openlp/songselectfileimport/+merge/33427
Your team OpenLP Core is subscribed to branch lp:openlp.