← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~raoul-snyman/openlp/song-wizard into lp:openlp

 

Review: Needs Fixing
Sorry, found another issue (I'm making slow progress converting my imports!)

The 3 occurrences of the signal 'process_events' should be 'openlp_process_events'

Also, could the 'openlp_stop_song_import' signal be renamed to 'songs_stop_import'? All plugin signals should start with the name of the plugin.


-- 
https://code.launchpad.net/~raoul-snyman/openlp/song-wizard/+merge/33496
Your team OpenLP Core is subscribed to branch lp:openlp.



References