openlp-core team mailing list archive

[Jon Tibble <meths@xxxxxxxxxxxxxx>]

Review: Needs Fixing
Bible title isn't stripping {su} tags.

Video playing is giving stack trace:
Traceback (most recent call last):
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\servicemanager.py", line 865, in makeLive
    self.serviceItems[item][u'service_item'], count)
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\slidecontroller.py", line 532, in addServiceManagerItem
    self._processItem(item, slideno)
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\slidecontroller.py", line 613, in _processItem
    self.onMediaStart(serviceItem)
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\slidecontroller.py", line 943, in onMediaStart
    self.display.video(file, self.volume)
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\maindisplay.py", line 273, in video
    return self.preview()
  File "D:\Projects\OpenLP\openlp\trb_renderer\openlp\core\ui\maindisplay.py", line 289, in preview
    if self.serviceItem.themedata.display_slideTransition:
AttributeError: 'NoneType' object has no attribute 'display_slideTransition'

Video stop button is pausing not stopping (i.e. pressing play after a stop should start from beginning not current place - playing after pause should resume from current location).

(Button tooltips are wrong but they're wrong in trunk too.)
-- 
https://code.launchpad.net/~trb143/openlp/renderer/+merge/33550
Your team OpenLP Core is subscribed to branch lp:openlp.