openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Tim Bentley has proposed merging lp:~trb143/openlp/renderer into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  #630285 OpeLP goes live on items even though a hide screen mode is active
  https://bugs.launchpad.net/bugs/630285


Proper fix!
-- 
https://code.launchpad.net/~trb143/openlp/renderer/+merge/34901
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/renderer into lp:openlp.

=== modified file 'openlp/core/ui/pluginform.py'
--- openlp/core/ui/pluginform.py	2010-09-08 17:51:19 +0000
+++ openlp/core/ui/pluginform.py	2010-09-08 19:52:41 +0000
@@ -58,6 +58,9 @@
         Load the plugin details into the screen
         """
         self.pluginListWidget.clear()
+        self.programaticChange = True
+        self._clearDetails()
+        self.programaticChange = True
         for plugin in self.parent.plugin_manager.plugins:
             item = QtGui.QListWidgetItem(self.pluginListWidget)
             # We do this just to make 100% sure the status is an integer as
@@ -134,6 +137,5 @@
         elif self.activePlugin.status == PluginStatus.Disabled:
             status_text = unicode(
                 translate('OpenLP.PluginForm', '%s (Disabled)'))
-        if self.pluginListWidget.currentItem():
-            self.pluginListWidget.currentItem().setText(
-                status_text % self.activePlugin.name)
+        self.pluginListWidget.currentItem().setText(
+            status_text % self.activePlugin.name)